search

kha7iq / pingme

PingMe is a CLI which provides the ability to send messages or alerts to multiple messaging platforms & email.
https://pingme.lmno.pk
MIT License
771 stars 43 forks source link

fix: use strconv.ParseInt instead of strconv.Atoi #49

Closed brenkem closed 3 years ago

brenkem commented 3 years ago

Regarding: https://github.com/kha7iq/pingme/issues/47

kha7iq commented 3 years ago

Thank you @brenkem for taking the time to make the changes. Everything is good to merge now, you have not set the username for your github when you made the commits. You can do so by setting it this way.

git config --global user.name "yourusername"
git config --global user.email "githubaccount@email.com"

Although its not an issue and i can merge, i will be happy if you get the recognition for your contributions. Do let me know if you would like to rebase and fix the commits, or should i continue to merge.

brenkem commented 3 years ago

I do only work under my account name. No need to change anything here. You can go and merge the change. No extra work needed here.

Thanks for your nice tool, have fun.

kha7iq commented 3 years ago

Well noted, and thanks once again