search

khanshoaib3 / stardew-access

An accessibility mod for Stardew Valley with screen reader and keyboard only support!
GNU General Public License v3.0
65 stars 19 forks source link

Luau Shop Menu Seems Glitchy #318

Open LucieG0 opened 2 months ago

LucieG0 commented 2 months ago

The menu seems to open fine at first, but if you move up or down more than one or two items, it glitches and the items are not read out. (Reported by @BrailleBennett ).

khanshoaib3 commented 1 month ago

@BrailleBennett The reason for it being glitchy is because the jungle decals and ceiling leaves have multiple variants with same name, I'll modify the patch to have it speak the name even if the previous item had the same name. I guess y'all also want them to be described right?

BrailleBennett commented 1 month ago

I mean, since nothing else is really described besides bobbers, pets/animals, and character stuff, you could either just number them or give like 1 or two word descriptions. Thanks for figuring this one out.

ParadoxiKat commented 3 weeks ago

I think it would be confusing to just repeat them; I.E. reading ceiling leaves twice is better than speaking nothing but is still not really informative. Numbering them still is better but also doesn't tell me which is which. What is different about them? How do the first one and the second one differ so I can make an informed choice for my purchase? @khanshoaib3 if you are / have already worked on this -- if you just put in placeholders for descriptive text I can have JJ actually describe them and can update the text. So if you just put in first leaves and second leaves for now we can fix the text later.

khanshoaib3 commented 3 weeks ago

What is different about them?

Well for instance the second jungle decal is flipped upside down version of the first one (kinda). The third one has two leaves and the fourth one is like a vine or something.

Here's a reference for both - jungle decals and ceiling leaves

if you just put in placeholders for descriptive text I can have JJ actually describe them and can update the text. So if you just put in first leaves and second leaves for now we can fix the text later.

I'll try, I think I can probably use the texture names as id's and provide that to fluent. Similar to the way we describe shirts and stuff in char creation menu.

khanshoaib3 commented 1 week ago

@ParadoxiKat Forgot to notify ya but I added the custom names support and also added the placeholders for the decals and others in en.ftl.