kheina-com / Blue-Blocker

Blocks all Twitter Blue verified users on twitter.com
Mozilla Public License 2.0
352 stars 27 forks source link

Add a consent popup for Firefox #375

Closed rougetimelord closed 1 week ago

rougetimelord commented 3 weeks ago

Fine, have your consent popup! Does that make you happy?

Probably should beautify the page a bit, but honestly, if having an ugly page is what it takes to get a working extension out to users I can live with it.

Thanks for all of the memories AMO team <3 Really feeling great about continuing to support your browser <3

cooljeanius commented 3 weeks ago

so, about those CI failures...

rougetimelord commented 3 weeks ago

so, about those CI failures...

T~T Look I had a beautiful woman impatiently telling me to wrap it up so we could go get drinks, all good now

cooljeanius commented 3 weeks ago

screenshot of what the pop-up looks like?

rougetimelord commented 3 weeks ago

screenshot of what the pop-up looks like?

It is ugly ugly, but I'd rather get a version that Firefox will approve out than worry about beautifying it first... image

kheina commented 3 weeks ago

please make bullets left text aligned (but aligned in the center of the page), buttons should be on their own row at the bottom

rougetimelord commented 3 weeks ago

please make bullets left text aligned (but aligned in the center of the page), buttons should be on their own row at the bottom

Here's what the page looks like now: image

Might need some work for super narrow screens (adding padding) but I got dinner to cook and eat

kheina commented 3 weeks ago

thank you! looks fine to me