search

khoih-prog / ESP32_ISR_Servo

This library enables you to use 1 Hardware Timer on ESP32-based board to control 16 or more servo motors. Now supporting ESP32, ESP32_S2, ESP32_S3, ESP32_C3-based boards. Tested OK with ESP32 core v2.0.5
MIT License
30 stars 9 forks source link

Add newer Adafruit boards #5

Closed brentru closed 2 years ago

brentru commented 2 years ago

Hi, we're looking into using this library with Adafruit WipperSnapper since its non-blocking.

Added #define's for some of the more recent Adafruit boards within arduino-esp32 BSP. Bump semver, please release when merged.

khoih-prog commented 2 years ago

@brentru

Merged and released shortly. Looking forward to receiving more PRs from you as there are too many new Adafruit boards I can't keep up updating.

Thanks.

brentru commented 2 years ago

@khoih-prog More boards during this time isn't a bad thing! Is there a way we can collapse this #define at all? or any of these?

Could you explain the #define for ESP32 a bit? I haven't seen this macro before - does it target ESP32 (non-c3/s2/..) boards such as the Feather HUZZAH32?

khoih-prog commented 2 years ago

Do you mean this https://github.com/khoih-prog/ESP32_ISR_Servo/blob/cc1b6a514c412bf987e9cdb8c2c68d47468d111d/src/ESP32_ISR_Servo.hpp#L42-L43

If so, it's trying to catch any ESP32 board not identified in previous defines, assuming it's a normal ESP32 (non C3, S2, S3, etc). Better than compile error.

brentru commented 2 years ago

Yes, I did mean L42. Good way of catching the non-Sx/-Cx boards!

khoih-prog commented 2 years ago

Hi @brentru

The new ESP32_ISR_Servo release v1.3.1 has just been published.

Your contribution is noted in Contributions and Thanks

Best Regards,

Releases v1.3.1

  1. Add support to new Adafruit boards such as QTPY_ESP32S2, FEATHER_ESP32S3_NOPSRAM and QTPY_ESP32S3_NOPSRAM