khushpanchal / Ketch

An Android File downloader library based on WorkManager with pause and resume support.
https://medium.com/@khush.panchal123/ketch-android-file-downloader-library-7369f7b93bd1
395 stars 26 forks source link

Support POST http method #2

Open glovebx opened 4 months ago

glovebx commented 4 months ago

The DownloadService currently only provides a GET method. I hope to add a POST method that can accept parameters annotated with @FieldMap

khushpanchal commented 4 months ago

Noted, I will plan for it.👍

dev-weiqi commented 4 months ago

A small suggestion: maybe we could let users provide their own DownloadService.

khushpanchal commented 3 months ago

As DownloadService is used by workmanager, we are only passing minimal info (config, primitive data) to inputData and Workmanager is independently running and downloading the file to disk. I think passing our custom DownloadService is not needed.

khushpanchal commented 1 month ago

@glovebx I have made a major change in library with support of pause and resume functionality. Version 2.0.0 , https://github.com/khushpanchal/Ketch You can check out and try new version. Feel free to create the PR with the above mentioned functionality, as it was not included in this release.

glovebx commented 1 month ago

@glovebx I have made a major change in library with support of pause and resume functionality. Version 2.0.0 , https://github.com/khushpanchal/Ketch You can check out and try new version. Feel free to create the PR with the above mentioned functionality, as it was not included in this release.

Thanks for your great work! I’ll check it out later.