search

khvzak / bluez-tools

A set of tools to manage bluetooth devices for linux
GNU General Public License v2.0
179 stars 53 forks source link

Memory leaks #20

Open nssilver opened 7 years ago

nssilver commented 7 years ago

The function g_ascii_strdown(), which is used in lib/manager.c, lib/properties.c, and lib/helpers.c returns a newly allocated string. These strings are compared, but the pointers to the strings aren't kept for subsequent free-ing.

nssilver commented 7 years ago

I've fixed most of the occurrences in manager.c and will fix the remainder soon. I'll create a pull request when I'm ready. I haven't done this before, so I may need some help/guidance.

appdev-w commented 7 years ago

Dear nssilver,

Let us know if you run into any issues. As I am sure you have encountered, here is a link to the pull request documentation: https://help.github.com/articles/creating-a-pull-request/

I have been focused on mobile development, but I will be sure to review the pull request and look into the other issues as well.

-Jack