search

ki-tools / kitools-py

Tools for working with data in Ki analyses
Apache License 2.0
3 stars 0 forks source link

`data_pull()` return a list of project resources instead of a vector of strings #24

Closed hafen closed 5 years ago

hafen commented 5 years ago

To be consistent with data_add(), data_pull() should probably return a list of project resources instead of a vector of strings. I think I originally asked for strings, but that was before I knew about the project resource return type.

pcstout commented 5 years ago

@hafen Only data_add() returns the resource object. data_pull/push return the absolute path(s). Should I make this change so all 3 methods return the resource object?

hafen commented 5 years ago

Yes I think it's good to be consistent. Unless you have any reservations about it.

pcstout commented 5 years ago

https://github.com/ki-tools/kitools-py/pull/31