Closed kingaa closed 2 years ago
:exclamation: No coverage uploaded for pull request base (
master@a6283d7
). Click here to learn what that means. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #11 +/- ##
=========================================
Coverage ? 57.60%
=========================================
Files ? 49
Lines ? 4071
Branches ? 0
=========================================
Hits ? 2345
Misses ? 1726
Partials ? 0
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a6283d7...8025f44. Read the comment docs.
Pinging to see if this pull request can be acted upon. Also: I note that Kidus' email address in the DESCRIPTION is out of date. Since that is used for communication with CRAN, it ought to be kept up to date.
I should have some time this week to look into this. In principle, I suppose it is fairly immediate, but as part of the transition it may be that I have questions for you. Ed.
Edward L. Ionides Director of Undergraduate Programs and Professor, Department of Statistics, University of Michigan 1085 South University, Ann Arbor, MI 48109-1107 email: @.*** phone: 734 615 3332 office: 453 West Hall
On Mon, Aug 1, 2022 at 11:03 AM Aaron A King @.***> wrote:
Pinging to see if this pull request can be acted upon. Also: I note that Kidus' email address in the DESCRIPTION is out of date. Since that is used for communication with CRAN, it ought to be kept up to date.
— Reply to this email directly, view it on GitHub https://github.com/kidusasfaw/spatPomp/pull/11#issuecomment-1201322608, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKAFT2EPHBOCBSAJMGEC3DVW7RMRANCNFSM5WB4XXOQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>
Aaron, Thanks for the pull request. Mostly, it looks great. There is something I don't understand in README.md
https://github.com/kingaa/spatPomp/actions/workflows/r-cmd-check.yml/badge.svg
Should we edit kingaa here to kidusasfaw? Perhaps you were doing this edit on your fork? Or is it something specifically set up on your github site? If the latter, I suppose we should set that up on kidusasfaw.
Thanks for merging this change, Ed. And my apologies for forgetting about this, Aaron. Great to see these CI pieces in place.
Kidus
Sent from my iPhone
On Aug 2, 2022, at 1:00 PM, Edward Ionides @.***> wrote:
Merged #11 into master.
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.
@ionides: Sorry I missed your comment. Yes, you did right to switch the badges.
This pull request incorporates github actions for checking, testing coverage, and building binaries under various platforms. These things can be tweaked more, but they seem to be a good start on a continuous-integration strategy that may streamline our code development.