search

kielabokkie / blueman

Convert a generated API Blueprint JSON file into a Postman collection
MIT License
149 stars 19 forks source link

Bug/support multiple uri params #6

Closed hendrikmaus closed 9 years ago

hendrikmaus commented 9 years ago

The command now supports multiple URI params, e.g. /players/{name}/{age} and URI params as well as query params at the same time, e.g. /players/{name}/{age}{?filter,locale}

Furthermore I added extensive unit testing for parsing URI's which cover most of the scenarios I often run into.

While working on the code, I split the original parseUri method into multiple sub-methods. parseUri itself just checks for URI and query params and replaces them.

I'd suggest creating version 1.1.3 after merging this.

kielabokkie commented 9 years ago

Hi @hendrikmaus. Thanks for the pull request! I'm really busy this close to Christmas but I'll have a look at it in the next couple of days and merge it in.

hendrikmaus commented 9 years ago

Very well, I am looking forward to your feedback.

kielabokkie commented 9 years ago

Thanks for the PR @hendrikmaus! It's merged in and just released v1.1.3.

hendrikmaus commented 9 years ago

@kielabokkie you're welcome