search

kimai / Paid-plugins

Support for paid Kimai plugins: Discussions and feature requests
https://www.kimai.org/store/
11 stars 1 forks source link

improve contract plugin working times view for team leads #140

Closed derStephan closed 8 months ago

derStephan commented 8 months ago

Describe the problem

In the working times view there is a user selection for administrators but not for team leads.

Describe the solution you'd like

It would be great to have the same user selection as for monthly reports if I am a team lead.

kevinpapst commented 8 months ago

That is a permission question: https://www.kimai.org/documentation/contract.html#permissions

You can always add more people / roles to the list of allowed people.

derStephan commented 8 months ago

I see, it is working now. Thanks for the information. However, now team leads can change planned working hours or vacancy days for the team including their own settings.

May I suggest to devide that in 2 different rights to prevent errors or fraud? One for simply viewing the working times and the other for changing user profiles.

kevinpapst commented 8 months ago

Oh yes, I missed that one. Thanks for sharing 👍

derStephan commented 7 months ago

Do you know, when this will be fixed? I am running the latest 1.10.0 but the issue remains.

kevinpapst commented 5 months ago

Upgrade to the latest Kimai version and then fetch the latest plugin version at https://license.kimai.org/

The combination of both should do the trick.

derStephan commented 5 months ago

I just upgraded the plugin to version 1.11.0 and run it in Kimai 2.17.0 and Team leads are still able to change their own expected number of hours, the link to /profile/<username>/contract is still working.

I did not find any permission to prevent it.

kevinpapst commented 5 months ago

One for simply viewing the working times and the other for changing user profiles.

I added this setting.

I did not find any permission to prevent it.

https://www.kimai.org/documentation/contract.html#permissions

derStephan commented 5 months ago

Ok, sorry. Must have missed it. Found the new permission contract_other_profile in user profile (other). It is working like a charm now. Thanks.