Open GoogleCodeExporter opened 9 years ago
Ooh, that's a cool image. It seems to work okay in Opera...Firefox has a
problem rendering just the image in the first place. And Chrome...whoa! :)
I'm pretty sure the problem lies with the matrix values that remove technically
unnecessary spaces, like here: matrix(.0809 .9967-.9967 .0809 315.47 549.74). I
suspect both Firefox and our transform-parser-for-webkit have a problem with
the ".9967-.9967" part. Think that ought to be easy to fix, so will give it a
shot (this is valid, btw, just not too common).
Original comment by adeve...@gmail.com
on 14 Oct 2010 at 12:46
On first glance it appears we take this:
"matrix(.9979-.0647 .0647 .9979 459.87 389.03)"
and turn it into this:
"matrix(0.9979,0.0647,0.9979,459.87,389.03,0) "
This is clearly not the same thing. I think we are taking the string
".9979-.0647" and parsing that as "0.9979", thus we are losing one of the
matrix numbers.
Original comment by codedr...@gmail.com
on 14 Oct 2010 at 4:55
Yep, it's right here on Line 1711
var val_arr = val_bits[1].split(/[, ]+/);
We are splitting the value by comma and space. You could sweep through first
and replace any minus sign with ' -' (ie inject a space before all minus or
plus signs). That'd be an easy way to do the fix and reuse all your other
parsing regex'es.
Original comment by codedr...@gmail.com
on 14 Oct 2010 at 5:00
Yup. Fixed in r1804.
Original comment by adeve...@gmail.com
on 14 Oct 2010 at 5:54
Looks great, but I noticed that svg-edit is stripping out the font-family
declaration. Not sure if this is the reason or not, but most of the text labels
on the left,top and bottom are still not in their correct position. Inkscape is
getting this correct - assuming of course that the svg is correct and that it
isn't working around a bug in Inkscape :)
Original comment by adrianbj...@gmail.com
on 14 Oct 2010 at 7:34
Fixed in r1807...though the file's still far from being properly editable.
Changing status to "Started" instead.
Currently when you select a label, it changes its style to the default
(fill=black and no stroke), which of course it shouldn't...it's just doing that
because it doesn't look like it has any styles, as the styles were assigned to
the group element. Will need to figure out how to deal with that best.
Another issue is that the path is largely uneditable, probably uses segment
types that we don't support yet.
Original comment by adeve...@gmail.com
on 15 Oct 2010 at 4:15
Original issue reported on code.google.com by
adrianbj...@gmail.com
on 14 Oct 2010 at 10:35Attachments: