Closed kaikae closed 1 month ago
The recent update focuses on improving the reliability of the application version retrieval within the KindeSDK.SDK.Utils
module. The method was modified to use Application.spec(:vsn)
instead of Mix.Project.config()
, ensuring that the version information aligns with the actual specifications in production environments. This reflects a shift towards a more production-ready implementation. Additionally, the output format is standardized by converting the version to a string.
File(s) | Change Summary |
---|---|
lib/kinde_sdk/sdk/utils.ex |
Modified get_current_app_version to use Application.spec(:vsn) for better production compatibility; output converted to string. |
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
LGTM
@onderay why did you assign the PR to me? I do not have write access to the Repo so I can not merge it, in case you don't want this to be merged feel free to close the PR.
Thanks for your work here @kaikae and for reviewing @femz12.
Will look at getting this deployed soon.
Explain your changes
When running our project in prod runtime with a packaged release we noticed following error:
This is caused since Mix is not packaged into the release - we decided to fork and use another way to fetch the application version.
Checklist