kinvolk / lokomotive

🪦 DISCONTINUED Further Lokomotive development has been discontinued. Lokomotive is a 100% open-source, easy to use and secure Kubernetes distribution from the volks at Kinvolk

https://kinvolk.io/lokomotive-kubernetes/

Apache License 2.0

320 stars 49 forks source link

Rename Packet to Equinix Metal in existing Documentation. #1537

Closed ipochi closed 3 years ago

ipochi commented 3 years ago

This PR replaces the name Packet with Equinix Metal in all the existing documentation resources under docs/

Fixes: #1060

This PR only takes care of renaming on the documentation side, more work and careful thought process would be required in migrating from Packet terraform provider to Equinix Metal terraform provider, such that there is little or no effect on existing clusters during upgrade.

More specifically, this migration guide will need to be followed https://registry.terraform.io/providers/equinix/metal/latest/docs/guides/migration_guide_packet

rata commented 3 years ago

@invidian @knrt10 I disagree, IMHO this address the issue taking into account the comment that we added during the sprint planning: https://github.com/kinvolk/lokomotive/issues/1060#issuecomment-866826019

ipochi commented 3 years ago

@invidian @rata @knrt10

The user facing documentation is whats visible to the end user more so that any other piece of code/config.

I understand your concern however, making it part of the single PR would have meant a possible delay of getting the user documentation changes merged, which was top priority anyway.

Hence I closed the original issue #1060 , created another issue #1546 that tracks the code and config related changes from Packet to Equinix Metal.

1545 tries to address #1546