search

kinvolk / lokomotive

🪦 DISCONTINUED Further Lokomotive development has been discontinued. Lokomotive is a 100% open-source, easy to use and secure Kubernetes distribution from the volks at Kinvolk
https://kinvolk.io/lokomotive-kubernetes/
Apache License 2.0
320 stars 49 forks source link

Add cred path variable similar to packet platform #220

Closed surajssd closed 4 years ago

surajssd commented 4 years ago

There is a variable in Packet configuration called aws_creds_path which allows me to specify the path to the credetials file. But AWS platform there is no way to do it.

Please add cred_pah var to AWS as well.

surajssd commented 4 years ago

Another alternative is using AWS_CONFIG_FILE which does not work with lokoctl as it is a standard env var that can be used with aws sdk https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-files.html

johananl commented 4 years ago

We don't need any vars or knobs for handling AWS credentials. All of this is already handled for us by the AWS SDK and any logic we add is just duplication.

For this specific case, setting the AWS_SHARED_CREDENTIALS_FILE env var has the desired effect.

johananl commented 4 years ago

Also, that knob has been removed from the Packet platform in #422.