search

kinvolk / lokomotive

🪦 DISCONTINUED Further Lokomotive development has been discontinued. Lokomotive is a 100% open-source, easy to use and secure Kubernetes distribution from the volks at Kinvolk
https://kinvolk.io/lokomotive-kubernetes/
Apache License 2.0
320 stars 49 forks source link

Remove CoreOS support from Terraform code #324

Closed invidian closed 3 years ago

invidian commented 4 years ago

For example, Terraform code for bare-metal provider still supports CoreOS, we should remove it.

invidian commented 3 years ago

Done for bare-metal in #1246. For AWS there is a PR #1245.

karlskewes commented 3 years ago

After those, the last one remaining is Azure I believe.

I had a look and it seems that it doesn't use os_channel or os_version variables like the others. It expects a var.custom_image_name to be supplied.

I haven't used Azure before and not sure how the data "azurerm_image" works (compared with AWS/GCP/etc). I wasn't able to find an image lookup website to learn how we can supply our usual flatcar, channel and version variables - if such a mechanism (not only Packer) exists.

invidian commented 3 years ago

I think we can ignore Azure for now, as it is not exposed in lokoctl. We will have to fix bunch of stuff there anyway when we decide to expose it.

invidian commented 3 years ago

Finished in #1245