search

kinvolk / lokomotive

🪦 DISCONTINUED Further Lokomotive development has been discontinued. Lokomotive is a 100% open-source, easy to use and secure Kubernetes distribution from the volks at Kinvolk
https://kinvolk.io/lokomotive-kubernetes/
Apache License 2.0
320 stars 49 forks source link

Delete components in CI before destroying the cluster. #576

Closed ipochi closed 4 years ago

ipochi commented 4 years ago

We should be deleting the components in CI before destroying the cluster. This would increase the running time for a CI job but it also adds checks for lokoctl component delete which we currently do not have.

Another example is external-dns component which creates DNS entries for dex and gangway component. However as the cluster is destroyed, those DNS records are not deleted and accumulate. If we allowed component deletion before destroying the cluster, such accumulation of DNS records wouldn't happen.

invidian commented 4 years ago

If we allowed component deletion before destroying the cluster, such accumulation of DNS records wouldn't happen.

In order to avoid accumulation to happen, we would have to ensure, that we don't shut down ExternalDNS until all records are removed, which is not trivial. But it will definitely help, as at least some records may get removed.

ipochi commented 4 years ago

If we allowed component deletion before destroying the cluster, such accumulation of DNS records wouldn't happen.

In order to avoid accumulation to happen, we would have to ensure, that we don't shut down ExternalDNS until all records are removed, which is not trivial. But it will definitely help, as at least some records may get removed.

I think if we delete the external-dns conponent last, then that should delete all the created dns records created by other components.

ipochi commented 4 years ago

Also the main point is e2e testing of lokoctl component delete. Clearing up DNS records would be the side benefit.

knrt10 commented 4 years ago

@ipochi if you are not working, I can take a look into this.

ipochi commented 4 years ago

@ipochi if you are not working, I can take a look into this.

Go ahead !! I am bit pre-occupied in NetworkPolicies.