search

kionell / osu-parsers

A bundle of decoders/encoders for osu! file formats based on the osu!lazer source code.
MIT License
38 stars 8 forks source link

beatLength, bpm calculation is wrong when bpm is > 10000 or bpm <1 #26

Closed KenZync closed 7 months ago

KenZync commented 7 months ago

image

image

KenZync commented 7 months ago

i cant access _beatLength that is correct because it is private

kionell commented 7 months ago

As I can see you are refering to osu!stable. Unlike osu!stable, in osu!lazer the beat length values are limited from 6 to 60 000 which means you can't have BPM below 1 or above 10 000. You can verify this yourself by looking at the game’s source code or simply by opening the map editor in osu!lazer. I don't think I can change that because it can affect star rating calculation, but I can expose raw value as a different property if you really need it.

KenZync commented 7 months ago

Expose RawBeatlength Yes Please!

kionell commented 7 months ago

Expose RawBeatlength Yes Please!

New properties already available in the newest update. You can use beatLengthUnlimited and sliderVelocityUnlimited to get full values. I want to add that osu!mania uses effect points and scroll speed rather than difficulty points and slider velocity. Scroll speed also has it's unlimited variant