kiranhart / Auction-House

Auction House is a complete auction system for your server.
20 stars 22 forks source link

Several bugs and confusion with instant buyout price and initial start price #54

Closed Evalutik closed 1 year ago

Evalutik commented 1 year ago

Everything described here applies to both a bunch of items and a single lot.

Bug 1:

Description:

When you try to place a lot in the auction format through the /ah sell menu, the start price changes badly. Let's say the default price for an instant buyout is 100 coins and the price of the start bid is also 100 coins. If you try to increase the start price from this menu while editing the lot before putting it up for sale, then nothing will work, because it cannot be more than the price for an iinstant buyout, however, no message about this appears. That is, the price just stays the same and new players get the impression that the increase in the initial price does not work.

To Reproduce:

Expected behavior:

image

Server info: Core: PurPur 1.19.3 Plugin Version: 2.93.0

Bug 2:

Description:

In the same menu as from Bug 1, if you first set the price for an instant buyout of 200 and then try to set the price for the starting bid to 150, then the starting price will be set to 100, which is half of 200. And it is always so: it is impossible to set the price for the starting bid more than half of the instant buyout price. However, as in Bug 1, there is no message about this.

Also, I would like players to be able to set any starting price up to the instant buyout price. So if the instant buyout price is 200, the player should be able to set any starting price below 200. Please note that if you list an item using the command /ah sell <price for instant buyout> <starting price> <bid step> then players can easily list an item with an instant buy price of 200 and a starting price of 200 or 150 or anything below 200 using the command /ah sell 200 150 10, and I'm fine with that, but it can't be done via the /ah sell menu!

To Reproduce:

Expected behavior:

Server info: Core: PurPur 1.19.3 Plugin Version: 2.93.0

Bug 3:

Description:

In the same menu as in Bug 1 and Bug 2, when you change the "Instant buyout option" parameter (On / Off), if this option is disabled from the menu, the ability to change the instant buyout price and the button for this should disappear.

In addition, if you first turn off the instant buyout option, set the starting price higher than the instant buyout price, and then turn on back the instant buyout option, players will be able to list an item with a starting price higher than the instant buyout price.

To Reproduce:

Expected behavior:

Server info: Core: PurPur 1.19.3 Plugin Version: 2.93.0

Everything described here applies to both a bunch of items and a single lot.