kirek007 / ws-osd-py

Generate OSD for Walksnail DVR! If you like it you can get me a coffe here https://www.buymeacoffee.com/kirek
42 stars 6 forks source link

[Request] Naming the files different! #15

Open Pairan opened 1 year ago

Pairan commented 1 year ago

Currently the generated png files are named ws_000000001.png and so one for every file.

If you however fly for longer and one flight has several video files then this causes extra work to get together again.

Could the files be named in a pattern that includes the source file? e.g. AvatarG0001_xxxxxx.png

processor.py :


    def render(self):
        self.osdGenStatus.update(0, 1, 0)

        video_size = self.video.get_size()
        if self.config.render_upscale:
            ff_size = {"w": 2560, "h": 1440}
        else:
            ff_size = {"w": video_size[1], "h": video_size[0]}

        ### HERE "ws" should be replaced by the source file name's sequence number ###
        out_path = os.path.join(self.output, "ws_%09d.png")
        ...

That would make it easier to attached the generated files to each other ( like if AvatarG0001+AvatarG0002+AvatarG0003 = ONE FLIGHT) WIth the current version I would have to rename all files to get them in the right sequence :)

kirek007 commented 1 year ago

Why not import all sequences and merge them in the video editor? (This is how I'm doing it)

Pairan commented 1 year ago

Because the flight consists of more videos and as such would overwrite the first parts as they have the same file names

kirek007 commented 1 year ago

Application will create a dedicated directory for each. Like this: image

Pairan commented 1 year ago

Yes … I’m aware of that

kirek007 commented 1 year ago

Yes … I’m aware of that

That's why I don't see any additional work that you have to do because of that. I'll consider this improvement in next versions, but I don't see personally any value in it.