search

kirek007 / ws-osd-py

Generate OSD for Walksnail DVR! If you like it you can get me a coffe here https://www.buymeacoffee.com/kirek
42 stars 6 forks source link

Initial Commit of CLI #43

Closed odgrace closed 1 year ago

odgrace commented 1 year ago

First shot at making a CLI utility to allow batch processing

kirek007 commented 1 year ago

Hey @odgrace this is exactly how I would do this! I'll take time later today to review and suggest few improvements before merge.

Thanks for contributing!

odgrace commented 1 year ago

What I'm missing here is the possibility to render one test frame so the user can validate provided parameters.

We could probably split this out so its like python3 cli.py test-frame --args

compared with something like the below for the main function python3 cli.py render-video --args

I've never done this before but I'm certain it's possible with argparse.

Another thing would be the creation of requirements-noui.txt files so it should work on any platform without crazy hacking around wxPython.

Yes good point - like how does this get packaged up. I got this working by cloning and just commenting out wxPython requirement because I had the issue with attrdict and I never really wanted the CLI! I don't know how this would work - like if this were on pypi would you have two packages, one derives from another? Like a core/CLI and -gui version? GUI takes core as a requirement and adds wx etc.

kirek007 commented 1 year ago

The CLI should be fairly simple to package into executables for all platforms. I would need to test it first tho.

kirek007 commented 1 year ago

Hey @odgrace It took some time, but I've reviewed it, added a few tweaks and for me, it's ready to merge :)