Simplify Install Task & Precompile Initializer

kirillplatonov / hotwire-livereload

Live reload gem for Hotwire Rails apps.

MIT License

483 stars 28 forks source link

Simplify Install Task & Precompile Initializer #18

Closed Ancez closed 2 years ago

Ancez commented 2 years ago

moved the if to be done inline so now instead of adding 3 lines, it adds 1 line to the layout

Ancez commented 2 years ago

@kirillplatonov let me know what you think of these changes 🙂 I hope you are well

I also wonder whether we could somehow get the js include tag to not be required in the app layout as realistically we want it in all the layouts (my example being the devise layout) so we either should be looping over all the layouts and inserting it to all of these or somehow get this outside of the app layouts 🤔🤷‍♂️

kirillplatonov commented 2 years ago

@Ancez one-line installer looks good to me 🙂

As for alternatives for including a livereload tag in the layout - I'm not sure about that. We could probably add rack middleware or after_action in the controller that will modify output HTML and inject script tag automatically.

kirillplatonov commented 2 years ago

@Ancez thanks for the work on this PR. I have to close it as another PR having similar changes has been merged: https://github.com/kirillplatonov/hotwire-livereload/pull/22