kirillzyusko / react-native-keyboard-controller

Keyboard manager which works in identical way on both iOS and Android
https://kirillzyusko.github.io/react-native-keyboard-controller/
MIT License
1.78k stars 81 forks source link

refactor: reusable `TextInput` protocol #696

Closed kirillzyusko closed 1 week ago

kirillzyusko commented 1 week ago

📜 Description

Put TextInput protocol in a separate directory to highlight that it's common protocol that can be re-used by other project files (not only traversal group).

💡 Motivation and Context

In preparation for offset functionality of interactive keyboard I discovered that we need to have common UITextField and UITextView interface to be able to manage some props without additional if-statements.

We already have our own TextInput protocol, so I thought we could benefit from it and extend it for future functionality. The only one thing is that now TextInput is associated with traversal group, but since it can be re-used by other groups I thought it would be better to move the file into its own separate group. That's what I did in this PR 🙂

📢 Changelog

iOS

🤔 How Has This Been Tested?

Tested on CI.

📝 Checklist

github-actions[bot] commented 1 week ago

📊 Package size report

Current size Target Size Difference
159558 bytes 159552 bytes 6 bytes 📈