MLsmd
commented
6 years ago Thank you @fwunsch for your review!
- [x] The setter method is a great idea! I implemented it.
- [x] The std::valarray is an interesting class template for scientific vector calculation! After looking deeper into it, I decided not to use it. The std::valarray would simplify the code in 3 cases (reduce a for loop to one line of code). The initialization and transfer from the pmt vector to the std::valarray, however, would compensate this improvement. Additionially, the overload of the non-member function std::begin(std::valarray) seems to be buggy and the code would be an ugly workaround.
- [x] I fixed the minor improvements in the code.
-Create C++ block diversity_combining_cc with SC capability. This closes #1. -Add MRC capability. This closes #2 and closes #3. -Add extensive QA tests. This closes #4. -Create .xml file for GRC. -Documentation for Doxygen.