kite-project / hope

A new web experience for your B2G and Android devices.
8 stars 3 forks source link

Making hope an addon #11

Closed etiennesegonzac closed 8 years ago

etiennesegonzac commented 8 years ago

Fixes #2 .

It's based on top of #10 , I'll wait for this one to land before asking for review here.

etiennesegonzac commented 8 years ago

Ready for review @wilsonpage :)

The CSS variables are defined in the system app. I can't see any way to make this meaningfully independent from the system app.

Once the scope is a bit more defined, we might be able to land more explicit hooks in the system app to make this better though.

jonathanKingston commented 8 years ago

:+1: works for me... not that I am involved in the project just interested :smile:.

Worth having npm install in the make addon?

etiennesegonzac commented 8 years ago

@jonathanKingston cool! yes npm install is required, I'll add it to the readme. Thanks!

wilsonpage commented 8 years ago

r+

etiennesegonzac commented 8 years ago

File #13