search

kite-project / hope

A new web experience for your B2G and Android devices.
8 stars 3 forks source link

Fxos icons #12

Closed jonathanKingston closed 8 years ago

jonathanKingston commented 8 years ago

Extends from: https://github.com/etiennesegonzac/hope/pull/11

The URL bar icons I kept the same as the reload icon looks quite different and the reader icon doesn't feature in the fxos-icons set.

I also think the home button would look better as something else also.

etiennesegonzac commented 8 years ago

Hey @jonathanKingston can you rebase and ask @wilsonpage for review ? :)

jonathanKingston commented 8 years ago

Sure, I noticed an alignment issue also so will fix.. not sure why it working before.

jonathanKingston commented 8 years ago

Hey @wilsonpage when you get time would you be able to review this? Perhaps after you have recovered from new year :smile:

I changed the url bar icon as it doesn't feature in the font. Also not sure of the home icon (it appeared to be double width so I had to force it's position) I also like the idea of the firefox icon there.

wilsonpage commented 8 years ago

Thanks for this @jonathanKingston! A few inline questions. I've also emailed one of the visual chaps to ask for the new SVG assets. Instead of bloating the current fxos-icons set, I think it would make sense to fork and replace icons as and when required.

jonathanKingston commented 8 years ago

@wilsonpage thanks for the review, I was just scouting about Mozilla repos to learn the ecosystem more. Feel free to tear this up etc if it's too much work to put in. The main issue I had as you mention is the missing icons which certainly would be worth adding to the icons either under new icon names or as a branch etc as you mention.

On holiday at the moment so might be light on the updates etc.

jonathanKingston commented 8 years ago

Closing in favour of: https://github.com/etiennesegonzac/hope/pull/22