Check if we can remove the make step for the addon

kite-project / hope

A new web experience for your B2G and Android devices.

8 stars 3 forks source link

Check if we can remove the make step for the addon #13

Closed etiennesegonzac closed 8 years ago

etiennesegonzac commented 8 years ago

@arcturus you might be able to help :)

jonathanKingston commented 8 years ago

Was not able to get it built onto b2gdroid with or without... however it could just be my setup the WebIDE requires 10 starts to install on my phone without it timing out.

wilsonpage commented 8 years ago

Do we even need the manifest.webapp anymore? Or do we still want to support this being able to replace the system app?

wilsonpage commented 8 years ago

I don't seem to require the Make step to flash an updated version of the add-on using WebIDE.

wilsonpage commented 8 years ago

Suggestions:

Remove manifest.webapp as it's not required right now and conflicts with manifest.json
Remove 'addon' Makefile task
Move scripts to package.json and remove Makefile

etiennesegonzac commented 8 years ago

Some of this will break the b2gdroid build!

On Mon, Jan 4, 2016, 7:16 AM Wilson Page notifications@github.com wrote:

Suggestions:

Remove manifest.webapp as it's not required right now and conflicts with manifest.json

Remove 'addon' Makefile task

Move scripts to package.json and remove Makefile

— Reply to this email directly or view it on GitHub https://github.com/etiennesegonzac/hope/issues/13#issuecomment-168663457 .

wilsonpage commented 8 years ago

Some of this will break the b2gdroid build!

Ah, I'm not aware of how the b2gdroid build works. Can it not use the addon?

etiennesegonzac commented 8 years ago

Ah, I'm not aware of how the b2gdroid build works. Can it not use the addon?

Well the goal is to use the native keyboard/notification tray. Seems super overkill to load all gaia into the apk and all the system app onto the phone just to show an iframe with an addon. And we'd still need a special build step to build the addon in/enable it by default.

So I really want to keep the b2gdroid support in. We need the manifest.webapp, the shallow profile dir and the profile Makefile task. Doesn't mean we can't clean it up :)

wilsonpage commented 8 years ago

Makes sense. Soz, I didn't know anything about the b2g-droid requirements.

etiennesegonzac commented 8 years ago

That's my bad. I'll write up an actually useful Readme.md, it should help :)

etiennesegonzac commented 8 years ago

I'm rewriting the Readme.md and taking a look at this issue at the same time.

etiennesegonzac commented 8 years ago

Fixed by #23