search

kite-project / hope

A new web experience for your B2G and Android devices.
8 stars 3 forks source link

WIP real iframes and url bar (issue #14) #16

Closed wilsonpage closed 8 years ago

etiennesegonzac commented 8 years ago

One less hacky way to solve the permission problem might be to make the hopeFrame just a <div> with a hope-tab-list inside and just add script tags to import the components. I don't think it'll be much more fragile than the current solution and it might make things a lot easier.

etiennesegonzac commented 8 years ago

This is incredibly exciting :)

If adding the setActive yields promising results feel free to then go ahead and merge this PR (minus the debug statements).

Not worried about the 10s of tiny follow ups that will follow, it'll be a good opportunity to add tests!

wilsonpage commented 8 years ago

Comments addressed. Prepare for landing :airplane: