search

kite-project / hope

A new web experience for your B2G and Android devices.
8 stars 3 forks source link

Hide URL bar on scroll (closes #17) #26

Closed wilsonpage closed 8 years ago

wilsonpage commented 8 years ago

@etiennesegonzac r?

This was the best was I could think of handling this. Open to alternative ideas :)

etiennesegonzac commented 8 years ago

I can scroll the top bar of every tab out while in the tabview. Which is cool but probably a bug :)

etiennesegonzac commented 8 years ago

In some cases the physics is off because of the scroll propagation. Maybe we need to fix #15 first? But I won't block on it if we fix the tabsview issue :)

And I like this simple reflow-free approach too!

etiennesegonzac commented 8 years ago

Maybe a snappoint would help too.

wilsonpage commented 8 years ago

But I won't block on it if we fix the tabsview issue

Which issue?

@etiennesegonzac r?

etiennesegonzac commented 8 years ago

Which issue?

The one where I can scroll tabs while in tabs view mode (I can scroll the previews).

wilsonpage commented 8 years ago

The one where I can scroll tabs while in tabs view mode (I can scroll the previews).

Ah yes, that is fixed now.

etiennesegonzac commented 8 years ago

Cool, I'll review soon!

wilsonpage commented 8 years ago

@etiennesegonzac I found the scroll-snap was interfering with .scrollTo() so have removed for the time being. Latest commit seems more solid, being smarter instead of hammering the .scrollTo() API.

r?

etiennesegonzac commented 8 years ago

Don't know if there's something wrong with my setup but I can't select a different tab anymore :/ And when entering the tabsview the url bar of the current tab doesn't appear.

etiennesegonzac commented 8 years ago

ha, that explains it :) TypeError: this.showBar is not a function"

wilsonpage commented 8 years ago

@etiennesegonzac r?

etiennesegonzac commented 8 years ago

Alright, ready to squash and land :)

One thing that I'm not sure I completely understand is why the .overlay isn't preventing the scrolling by itself (causing us to to pretty big reflows to change the overflowY), but we can investigate in a follow up.

wilsonpage commented 8 years ago

One thing that I'm not sure I completely understand is why the .overlay isn't preventing the scrolling by itself (causing us to to pretty big reflows to change the overflowY), but we can investigate in a follow up.

This could work if overlay was a sibling to a scrollable container that contained .bar and .content.

wilsonpage commented 8 years ago

@etiennesegonzac squashing and landing.