search

kite-project / hope

A new web experience for your B2G and Android devices.
8 stars 3 forks source link

Testing scrollend. #28

Closed etiennesegonzac closed 8 years ago

etiennesegonzac commented 8 years ago

Its pretty cool :) And would surely help with the URL bar!

Maybe we need a way to detect the availability and shim it otherwise.

Just opening the PR to get the conversation going.

etiennesegonzac commented 8 years ago

We can probably just add a safety timeout for scrollTo and it'll make this patch landable (once the gecko patch lands too, + the ones to turn on the pref).

What do you think @wilsonpage ?

wilsonpage commented 8 years ago

Can you summarise what improvements this patch (ie. scrollend) brings.

etiennesegonzac commented 8 years ago

Summary

When you are at the bottom of the tabsview and press the "+" button, we scroll to the top then insert the new tab. Currently we scroll to the top, then wait for 350ms after the last scroll event, then insert the new tab.

With the scrollend this delay gets a lot shorter.

etiennesegonzac commented 8 years ago

comments addressed @wilsonpage :)

etiennesegonzac commented 8 years ago

should be better now @wilsonpage :)

etiennesegonzac commented 8 years ago

I'm piling up a bit on this PR :)

wilsonpage commented 8 years ago

I'm piling up a bit on this PR :)

You need r?