Implement a URL sanitizer to check for invalid URLs and Search or add…

kite-project / hope

A new web experience for your B2G and Android devices.

8 stars 3 forks source link

Implement a URL sanitizer to check for invalid URLs and Search or add… #38

Closed jonathanKingston closed 8 years ago

jonathanKingston commented 8 years ago

… a protocol otherwise. Fixes #33

jonathanKingston commented 8 years ago

Typing 'scripting.com' will take you to 'https://scripting.com' then to 'http://scripting.com' when the URL fails. This however should not (and should never) downgrade standard navigation within the tab in this manner.

etiennesegonzac commented 8 years ago

That's a huuuge usability win, thanks @jonathanKingston ! There's 2 small comments to address but we can land it afterwards, we'll wait for #36 to add tests :)

jonathanKingston commented 8 years ago

@etiennesegonzac thanks for checking this over. Yup wasn't sure if the location change fired on user initiated changes thanks for prompt Should be ready for your review again.

etiennesegonzac commented 8 years ago

\o/