kite-project / hope

A new web experience for your B2G and Android devices.
8 stars 3 forks source link

The hope-tab's iframes are not really remote #48

Closed etiennesegonzac closed 8 years ago

etiennesegonzac commented 8 years ago

good news is, it probably explains most of the performance issue we have. bad news is, it might be tricky to fix.

But when watching b2g-ps with hope or with classic gaia you can definitely see that we're not creating new processes for tabs.

etiennesegonzac commented 8 years ago
diff --git a/lib/hope-tab.js b/lib/hope-tab.js
index 49974b1..c573b25 100644
--- a/lib/hope-tab.js
+++ b/lib/hope-tab.js
@@ -379,17 +379,17 @@ window.HopeTab = fxosComponent.register('hope-tab', {
               <div class="input">
                 <input type="search" x-inputmode="verbatim"/>
               </div>
               <button class="refresh" data-icon="reload"></button>
             </form>
           </div>
         </div>
         <div class="browser">
-          <iframe mozbrowser remote></iframe>
+          <iframe mozbrowser="true" remote="true"></iframe>
         </div>
       </div>
       <div class="overlay"></div>
       <div class="tab">
         <h3 class="title"></h3>
         <button class="close" data-icon="close"></button>
       </div>
     </div>

By doing this I can see new processes being spawned up and the reactivity of the tab UI while loading heavy web pages goes from "unacceptable" to "pretty much perfect" :)

Tiny issue, then I can't open any new tab... still looking.