search

kite-project / hope

A new web experience for your B2G and Android devices.
8 stars 3 forks source link

Use WeakMap to track events attached to an element. Fixes #50 #51

Closed jonathanKingston closed 8 years ago

jonathanKingston commented 8 years ago

@etiennesegonzac I'm not seeing the same issues with lib/app.js however if that happens this method should likely be an import to both files.

etiennesegonzac commented 8 years ago

lib/app.js is only loaded in the iframe we remove so it shouldn't cause any troubles.

And looks like this should do the trick :) Can you rename eventStore to something a little less generic (kiteEventStore maybe) and add a small comment explaining why we do this dance?

Then this should be good to go!

jonathanKingston commented 8 years ago

@etiennesegonzac should be ok now. Was considering a window.kite object as a parent but that can always be added in later I guess.