search

kiwicom / gitlab-unfurly

Serverless Slack bot for unfurling GitLab URLs.
MIT License
39 stars 7 forks source link

Respect removed previews #10

Closed rkuska closed 5 years ago

rkuska commented 5 years ago

I create a post containing many gitlab links and unfurly automatically unfurls them. Yet when I click on x at every relevant link unfurly will again generate the views. I would expect unfurly to respect removed previews.

I understand that unfurly is probably stateless but then I would expect to have an (easy) option to not unfurl any link in the post.

underyx commented 5 years ago

Yep, just add ?no_unfurl to the URL and it will be skipped.

martin-sucha commented 5 years ago

Couldn't clicking the x add it automatically?

underyx commented 5 years ago

And the behavior you describe sounds like a bug on Slack's end, no? Why does Slack ask unfurly for link details again? Please report it to them.

rkuska commented 5 years ago
  1. Can this to be adjusted for the whole post? It's tiresome to add it to every url.
  2. Can this be documented?
underyx commented 5 years ago

@martin-sucha we have rights only to read URLs, so no.

underyx commented 5 years ago

@rkuska as for 1, Slack gives us the individual URLs, not even the whole message, so no. As for 2, pull requests welcome 😌

rkuska commented 5 years ago

As for 2, done.