Open RohanBh opened 6 years ago
Sounds good I would cap it at a certain distance though. Try playing around and working out what might be best.
This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.
This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.
Per default it shoudl open with the same tabs (and not the library), but this behaviour should be driven by a new settings: "remember open tabs when existing"
EDIT: forget this comment
"remember open tabs when existing"
@kelson42 Isn't this ticket about remembering the back stack of pages?
Why does it sound like dupe of https://github.com/kiwix/kiwix-android/issues/2582 or vice-versa
@s-ayush2903 Indeed! Closing
This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.
Currently, we are using the inbuilt functions of webview for going forward and backwards. So in order to maintain a backstack we have to make our own manager which saves the pages while moving to the next pages right? Or do we have to do it any other way?
@rishujam Assuming #3042, the we should just have an import/export feature tomRoom DB (we should wait that new Room DAO to be merged).
@Kelson, I need some clarifications to get started on this issue.
Should the solution only focus on saving and restoring the in-article back/forward navigation history, or is the goal to preserve both, the history of visited articles and the internal navigation?
Currently, the forward and backward navigation history within an article relies on WebView history ( #3042 ), which is lost when the app restarts. Should the plan be to store this unified list of visited articles/pages in the Room database to ensure persistence across sessions?
At this stage this is only about saving/restoring the navigation history. But restoring tabs will come next, so you should save the history for each tab separatly. Yes, Room should be used for that.
@Saifuddin53 Requirements all all clear to you? Have you been able to make progresses?
Yes @kelson42 all clear and have started working on it.
@Saifuddin53 Any update on this? if you need any help on this then let me know.
@MohitMaliFtechiz Sir, I am going to store the WebBackForwardList in Room, and then when the reader is opened, I will split it into back and forward lists. After that, I'll restore the web history based on these lists. Let me know if this approach sounds good or if there's anything you'd suggest!
Are you saving the WebBackForwardList in the room database on every page load? Please make sure to store the latest history in the database. Once your work is done open a PR so that we can review your work.
Are you saving the WebBackForwardList in the room database on every page load?
I will store the WebBackForwardList in the Room database when the reader fragment's onPause() is called, and on onResume(), I will retrieve the list and restore the history. And once it's done, I'll open a PR for review.
Currently, the back stack of pages is lost when the app is restarted. Chrome on Android remembers the order of visited pages if same happens to it. This must be the expected behavior.
Would you like to work on it? Yes