search

kiyo-masui / bitshuffle

Filter for improving compression of typed binary data.
Other
219 stars 76 forks source link

Support numpy 2.0.0 #152

Closed mattjala closed 1 month ago

mattjala commented 4 months ago
t20100 commented 2 months ago

It would be great to have a version with numpy 2 support!

jreadey commented 1 month ago

@t20100 - it looks like the bitshuffle repo isn't being actively maintained. If ESRF would be willing to fork it with Matt's PR changes, I'd be happy to switch the HSDS dependency to your package.

t20100 commented 1 month ago

@jreadey there's certainly a better approach than forking the project.

@kiyo-masui the lack of a release of bitshuffle with support of numpy v2 prevents projects depending on it to support numpy v2.

Would you have some time to review this PR and make a release? or eventually open this project to other core developers so someone else can do it?

kiyo-masui commented 1 month ago

Yes, I can take a look. I have to check what the status of continuous integration is on this repo - I thought it was set up but I don't see that anything was run. Do the current unit tests all pass?

kiyo-masui commented 1 month ago

So I'm very rusty and cannot figure out why CI isn't running for PRs from forks. I thought it was this, and indeed I have the "Require approval for first-time contributors" set, but I don't see an "approve and run" button.

Second issue is that all the CIs fail at the stage where they install dependancies, so once we get the actions to run, we need to actually fix the test.

Let me know if there is something obvious I'm missing.

t20100 commented 1 month ago

I never saw this...

Maybe the github actions workflow were disabled (if so there's a banner here: https://github.com/kiyo-masui/bitshuffle/actions/workflows/main.yml)? :shrug:

t20100 commented 1 month ago

The macos github action runners have been updated and runs on arm64 machines, that's probably going to cause trouble: See https://github.com/kiyo-masui/bitshuffle/pull/142#issuecomment-1566137447

mattjala commented 1 month ago

Hm, the CI succeeded 3 months ago. I'll look into what changed and hopefully get a fix out soon.

kiyo-masui commented 1 month ago

I see, they are running on the actions for the fork, as opposed to my original repo. That's good enough for me - I just have to click more to find the CI results. Note that I just merged another PR, so you will have to merge that back in and run the CI.

mattjala commented 1 month ago

Looks like the fix for filters that just got merged in fixed the build. I also updated a link since the HDF5 documentation has moved around recently.