search

kjdev / nginx-auth-jwt

Nginx module for the authenticate using JWT
MIT License
27 stars 17 forks source link

#8 Add new directives #9

Closed AlekseySVTN closed 12 months ago

AlekseySVTN commented 1 year ago

INFO: https://github.com/kjdev/nginx-auth-jwt/issues/8

kjdev commented 1 year ago

please fix the code style

ex: style-diff.txt

kjdev commented 1 year ago

I want you to commit for each feature.

kjdev commented 1 year ago

Since auth_jwt_locked_subs_list_file and auth_jwt_revocation_kid_list_file have similar functions, it is better to have similar names for the directives.

The target is sub or kid in the list that refuses authentication.

AlekseySVTN commented 12 months ago

Hello kjdev!

Sorry for the late answer, I was on vacation last week. Thank you for your review, I have tried to fix all your suggestions.

After all fixes, I have pushed updates with force flag. If it is a problem, please text me, we will resolve it.

Please, look at these fixes below.

please fix the code style

  • 2 indent
  • 80 columns
  • line break at end of file ..

ex: style-diff.txt

I have applied your patch, thank you. If there are any other style-issues, please, say it, I will fix them too.

Since auth_jwt_locked_subs_list_file and auth_jwt_revocation_kid_list_file have similar functions, it is better to have similar names for the directives.

The target is sub or kid in the list that refuses authentication.

Fixed. They were renamed to:

I want you to commit for each feature.

  • auth_jwt_locked_subs_list_file
  • auth_jwt_revocation_kid_list_file
  • auth_jwt_require_claim
  • auth_jwt_require_header

If I correctly understand, you would like to see something like: one feature -> one commit in git line. If so - fixed. Commits:

8 Add auth_jwt_require_header directive

8 Add auth_jwt_require_claim directive

8 Add auth_jwt_revocation_list_kid

8 Add auth_jwt_revocation_list_sub

kjdev commented 12 months ago

merged 31bc9d70cea994188d010bab32fefb66e17298e6

kjdev commented 12 months ago

Thanks.