Open mp1pro opened 6 years ago
kjdurrum24
commented
6 years ago Sorry about that. I resubmitted with the images folder. Although, I know code may not be reviewed twice once it is submitted just wanted to make sure I cover all my basis. Thank you!
mp1pro
commented
6 years ago Very nice adding the images folder. One more thing, Instead of
background-image: url(file:///Users/kenessa/Desktop/CODE-projects/tea-cozy/resources/images/img-mission-background.jpg);
use a relative path
background-image: url(./images/img-mission-background.jpg);
In order for the images to load outside of your local environment.
To get the image filling the background of locations, instead of
#locations {
background-image: url(./images/img-locations-background.jpg);
height: 500px;
padding: 70px;
background-size: cover;
text-shadow: 1px 3px 5px black;
background-position-y: -427px;
}use
#locations {
background-image: url(./images/img-locations-background.jpg);
height: 500px;
padding: 70px;
background-size: cover;
}Thank you Marvin! I tried "background size: cover;" and wasn't getting the image how I wanted but I suppose it might be due to varying screen sizes. And thank you for the relative path refresher. I had some trouble with it on my last project so I opted for the full url.
On Tue, May 29, 2018, 10:14 AM Marvin Parke notifications@github.com wrote:
Very nice adding the images folder. One more thing, Instead of
background-image: url(file:///Users/kenessa/Desktop/CODE-projects/tea-cozy/resources/images/img-mission-background.jpg);
use a relative path
background-image: url(./images/img-mission-background.jpg); In order for the images to load outside of your local environment.
To get the image filling the background of locations, instead of
locations {
background-image: url(./images/img-locations-background.jpg); height: 500px; padding: 70px; background-size: cover; text-shadow: 1px 3px 5px black; background-position-y: -427px; }
use
locations {
background-image: url(./images/img-locations-background.jpg); height: 500px; padding: 70px; background-size: cover; }
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/kjdurrum24/tea-cozy/issues/1#issuecomment-392792001, or mute the thread https://github.com/notifications/unsubscribe-auth/AlORw5amBx2pbqnHyn_WDl9hV9JalujIks5t3Ve2gaJpZM4URask .
The images folder was not uploaded with the project