search

kjnh10 / saseg_runner

Run egp file from python
MIT License
10 stars 2 forks source link

Double quotes around file path #22

Open aaronsmith1234 opened 2 years ago

aaronsmith1234 commented 2 years ago

Hi, Thanks for the good work on this! Cool project.

I'm running on a Windows machine, and if I don't include double quotes around the vbs script path, I get an error. I'm surprised you aren't getting an error as well; are you using Windows or some other platform?

image

aaronsmith1234 commented 2 years ago

Happy to submit a pull request with the change if you're willing to push it to pypi; just wanted to make sure there wasn't a reason those had been left off. @kjnh10 thanks again!

kjnh10 commented 2 years ago

Thanks for reporting and PR. I will check this later today.

aaronsmith1234 commented 2 years ago

https://github.com/kjnh10/saseg_runner/pull/23

kjnh10 commented 2 years ago

I'm using windows and did not encounter the error. I guess that your installation path ({SCRIPTDIR_PATH}) incluedes special characters like space.

Anyway, I think quoting is better. I have merged your pull request and uploaded this change to pypi as version 0.1.14.

Thanks very much.

aaronsmith1234 commented 2 years ago

Cool; @kjnh10 can you add me as someone who can open branches on this repo? Have a few other minor changes that I think could help the tool.

aaronsmith1234 commented 2 years ago

Thanks @kjnh10. How tied are you to the repo structure\how much of an active user of it are you? I'd be happy to set up documentation with sphinx and read the docs; also would like to do some minor remodeling of the code and test structure, maybe move from click to rich, but I also don't want to step on any toes or anything!

kjnh10 commented 2 years ago

@aaronsmith1234

I created this project for the work of the company I work for. I'm generally happy with the functionality, but I don't feel it's completely polished either. (We have about 5 or 6 users in our company.)

So better structure, testing, etc. would of course be welcome. (And documentation, of course!).

For the time being, it would be preferable for you to propose changes on a separate branch, and I will review and merge them to master.