search

kkiyama117 / coc-toml

Toml extension for coc-nvim, using taplo for lsp engine
https://www.npmjs.com/package/coc-toml
MIT License
60 stars 1 forks source link

[feature] Use schema store to get json schema #115

Open Freed-Wu opened 9 months ago

Freed-Wu commented 9 months ago

https://github.com/kkiyama117/coc-toml/blob/main/src/index.ts#L64

Why not use schemastore to get json schema?

Related issue: https://github.com/neoclide/coc-json/issues/75

Freed-Wu commented 9 months ago

https://taplo.tamasfe.dev/configuration/developing-schemas.html#publishing:

Submitting schemas directly to Taplo is not possible anymore, and all JSON schemas should be submitted to the JSON Schema Store.

Freed-Wu commented 9 months ago

Yes, https://github.com/tamasfe/taplo/tree/master/editors/vscode use schemastore.

kkiyama117 commented 9 months ago

I think it is a very good suggestion, as are the other issues you have put up. I will work on it later if I can find the time, but I am currently a university student and I don't think I will have time to work on it for another month or so due to my graduation thesis, remaining credits and graduate exams. This coc-toml is based on the alpha version of taplo's plugin for vscode, modified to fit the configuration of other coc plugins. If I remember correctly, taplo is now in a different major version from that time, and I think there are discrepancies in some functions and links such as schema, etc. because the internal structure is different. If you want these features immediately and can use Node.js, I hope you can make the changes and create a PR.

kkiyama117 commented 9 months ago

Also, I now use a plugin structure in vim based on the denops ecosystem and do not use coc in main. That, and the private reasons mentioned above, have slowed down the updating of coc-toml. If you use coc regularly and you or someone you know is familiar with coc, nodejs or vim, and you are interested, please let me know in a separate issue as I will transfer this repository.

Freed-Wu commented 9 months ago

someone you know is familiar with coc, nodejs or vim

How about https://github.com/coc-extensions?

kkiyama117 commented 9 months ago

Sure. I'll discuss it there when I can take the time to reply properly.