Closed bartkrekelberg closed 4 years ago
This looks OK to me. The only thing that I was unsure about was:
isSubject = isa(o,'neurostim.stimulus');
Is there a reason that it should default to the subject/experimenter if it is/isn't a stimulus? e.g. why would behaviour key presses default to experimenter? Should it perhaps just be true by default, or that you are forced to say which keyboard should be listened to?
This is code from when behaviors did not exist yet. The idea was that plugins (i.e. not stimuli) should be handled by the experimenter. I'll change the code to default to true unless a non-stimulus plugin.
Bart Krekelberg, PhD
Professor, Rutgers University - Newark
Co-Director, Center for Molecular and Behavioral Neuroscience
Associate Director, Rutgers University Brain Imaging Center
197 University Avenue
Newark, NJ 07102
T: +1 551 285 9265
E: bart@rutgers.edu
W: vision.rutgers.edu
Skype: bartkrekelberg
From: Adam Morris notifications@github.com Sent: Monday, March 16, 2020 2:38 To: klabhub/neurostim-ptb neurostim-ptb@noreply.github.com Cc: Bart Krekelberg bart@vision.rutgers.edu; Author author@noreply.github.com Subject: Re: [klabhub/neurostim-ptb] Force keyfmri (#148)
This looks OK to me. The only thing that I was unsure about was:
isSubject = isa(o,'neurostim.stimulus');
Is there a reason that it should default to the subject/experimenter if it is/isn't a stimulus? e.g. why would behaviour key presses default to experimenter? Should it perhaps just be true by default, or that you are forced to say which keyboard should be listened to?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fklabhub%2Fneurostim-ptb%2Fpull%2F148%23issuecomment-599300005&data=02%7C01%7Cbart%40rutgers.edu%7C8b3e4c80878e441e584c08d7c94acec4%7Cb92d2b234d35447093ff69aca6632ffe%7C1%7C1%7C637199195444710228&sdata=694WO0h68lJf7PdgRLfJ4KGd9iYQlSNsjrVuGXN9CSE%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAC3MRU6AL2HQMQDHKEPHX7TRHV7LDANCNFSM4LGMOZYQ&data=02%7C01%7Cbart%40rutgers.edu%7C8b3e4c80878e441e584c08d7c94acec4%7Cb92d2b234d35447093ff69aca6632ffe%7C1%7C1%7C637199195444710228&sdata=UNl8hBydNOxsFZ0RRWjcU3MFul2H1xXeDJpGSJnmowc%3D&reserved=0.
For an fMRI plugin I need to temporarily move keys from one plugin to another. I added some code in plugin.m and cic.m that makes this possible. It should not interfere with any older code.