search

klappvisor / haskell-telegram-api

Telegram Bot API for Haskell
BSD 3-Clause "New" or "Revised" License
201 stars 67 forks source link

`getUpdates` must accept parameters #88

Closed cblp closed 7 years ago

cblp commented 7 years ago

This change is Reviewable

klappvisor commented 7 years ago

to me it looks like export getUpdatesM' (that accepts GetUpdatesRequest) would be enough

cblp commented 7 years ago

But current getUpdatesM is too trivial, it is not useful without any parameters. But if user wants, they can just call getUpdates getUpdatesRequest.

klappvisor commented 7 years ago

yes, it is for simple use. so getUpdatesM' can be used (once exported) for more complex use cases, but I see your point. tbh now after thinking about it more I would swap methods with prime and without it to have getUpdatesM that accept request and prime version that does not. but my concern is again backward compatibility. it's already not so good, will it make it worse?

cblp commented 7 years ago

I think any solution of these is good.