Split the FPS higher-order component into two

klarna / higher-order-components

A collection of useful React higher-order components

MIT License

129 stars 18 forks source link

Open xaviervia opened 7 years ago

xaviervia commented 7 years ago

One (possibly withFPSGauge) should just report the fps as a prop and provide the onFPS callback
Another one (possibly withLowFPSReport) should have the current API, and build around the withFPSGauge

Nevon commented 7 years ago

Obviously this is just nitpicking, but why FPSGauge? withFPS or withFPSMetric seems like a more obvious name.

xaviervia commented 7 years ago

withFPS sounded too generic to me. I don’t know though, naming is hard, and naming this abstract stuff is even harder.