coderabbitai[bot]
commented
1 month ago Walkthrough
The pull request introduces modifications to the GraphQL schema and related TypeScript files, focusing on the User entity and its metrics. New fields totalCoherentVotes, totalResolvedVotes, and coherenceScore are added, while the totalCoherent field is removed. Changes in the KlerosCore.ts file enhance the handling of juror votes, and various components and hooks are updated to reflect the new field names and structures.
Changes
| File Path | Change Summary |
|---|---|
| subgraph/core/schema.graphql | - Added fields: totalCoherentVotes: BigInt!, totalResolvedVotes: BigInt!, coherenceScore: BigInt! in User.- Removed field: totalCoherent: BigInt! in User. |
| subgraph/core/src/KlerosCore.ts | - Added import: ClassicVote.- Enhanced handleNewPeriod function for juror vote processing. |
| subgraph/core/src/entities/User.ts | - Updated createUserFromAddress to use new properties.- Simplified resolveUserDispute function parameters and logic. |
| web/src/hooks/queries/useTopUsersByCoherenceScore.ts | - Renamed field in query: totalCoherent to totalCoherentVotes, added totalResolvedVotes. |
| web/src/hooks/queries/useUser.ts | - Renamed field in fragment: totalCoherent to totalCoherentVotes, added totalResolvedVotes. |
| web/src/pages/Dashboard/JurorInfo/Coherency.tsx | - Updated ICoherency interface and component props to use new property names. |
| web/src/pages/Dashboard/JurorInfo/Header.tsx | - Updated IHeader interface and component props to use new property names. |
| web/src/pages/Dashboard/JurorInfo/index.tsx | - Renamed variables from totalCoherent to totalCoherentVotes and from totalResolvedDisputes to totalResolvedVotes. |
| web/src/pages/Home/TopJurors/JurorCard/Coherency.tsx | - Updated ICoherency interface and component props to use new property names. |
| web/src/pages/Home/TopJurors/JurorCard/DesktopCard.tsx | - Updated IDesktopCard interface to rename properties. |
| web/src/pages/Home/TopJurors/JurorCard/MobileCard.tsx | - Updated IMobileCard interface to rename properties. |
| web/src/pages/Home/TopJurors/JurorCard/index.tsx | - Updated IJurorCard interface to rename properties. |
| subgraph/package.json | - Version updated from 0.7.4 to 0.7.6. |
Possibly related issues
- kleros/kleros-v2#1334: The changes in this PR may address the issue of calculating
coherenceScoreat the vote level, as the new fields and logic enhance how coherence is tracked.
Possibly related PRs
- #1671: The changes in this PR involve modifications to the GraphQL queries to include new fields like
totalCoherentVotesandtotalResolvedVotes, which directly relate to the changes made in the main PR regarding theUserentity in the GraphQL schema.
Suggested labels
Type: Feature🗿, Package: Web
Suggested reviewers
- Harman-singh-waraich
- alcercu
Poem
🐰 In the realm of votes and scores,
A rabbit hops through open doors.
With coherent votes now shining bright,
User metrics take their flight!
A new dawn for jurors, clear and true,
Hooray for changes, fresh and new! 🌟
netlify[bot]
codeclimate[bot]
sonarcloud[bot]
works good.
Summary by CodeRabbit
Release Notes
New Features
totalCoherentVotes,totalResolvedVotes, andcoherenceScore.ClassicVote, for improved dispute resolution.Improvements
Configuration
0.7.4to0.7.6.PR-Codex overview
This PR primarily focuses on renaming properties related to user voting metrics from
totalCoherenttototalCoherentVotesand updating the associated logic throughout the application. It also enhances the user level calculation by introducing minimum disputes criteria.Detailed summary
totalCoherenttototalCoherentVotesin various files.totalResolvedVotesin multiple components.getUserLevelDatato includetotalResolvedDisputes.computeCoherenceScoreto usetotalCoherentVotesandtotalResolvedVotes.resolveUserDisputefunction to simplify parameters and logic.