Closed Harman-singh-waraich closed 3 weeks ago
The changes in this pull request involve the removal of the TestnetBanner
component from the Header
layout in the Kleros V2 application. This deletion eliminates the display of a testnet status banner and the associated environment-specific logic from the Header
component. Additionally, the padding of the HeaderContainer
styled component has been modified to adjust the layout's vertical spacing.
File Path | Change Summary |
---|---|
web/src/layout/Header/TestnetBanner.tsx |
Component removed: TestnetBanner functional component. |
web/src/layout/Header/index.tsx |
- Import removed: isProductionDeployment . - Component removed: <TestnetBanner /> . - Padding updated from 4px 24px 8px to 8px 24px in HeaderContainer . |
sequenceDiagram
participant User
participant Header
participant TestnetBanner
User->>Header: Request Header
Header->>TestnetBanner: Check if TestnetBanner should render
Note right of Header: TestnetBanner not rendered
Header->>User: Render Header without TestnetBanner
🐇 "Oh, the banner is gone, what a sight!
No more testnets to share in the light.
The header's now simple, with padding anew,
A cleaner design, just for you!
Hopping along, we embrace the change,
In our code garden, we rearrange!" 🐇
Name | Link |
---|---|
Latest commit | b837ec790dce0eade008f6a3bad66cb0f7f30f9a |
Latest deploy log | https://app.netlify.com/sites/kleros-v2-university/deploys/672b13d0cf076900082755fa |
Deploy Preview | https://deploy-preview-1738--kleros-v2-university.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Name | Link |
---|---|
Latest commit | b837ec790dce0eade008f6a3bad66cb0f7f30f9a |
Latest deploy log | https://app.netlify.com/sites/kleros-v2-neo/deploys/672b13d024069f0008053410 |
Deploy Preview | https://deploy-preview-1738--kleros-v2-neo.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Name | Link |
---|---|
Latest commit | b837ec790dce0eade008f6a3bad66cb0f7f30f9a |
Latest deploy log | https://app.netlify.com/sites/kleros-v2-testnet/deploys/672b13d0a1bc310008b48eb4 |
Deploy Preview | https://deploy-preview-1738--kleros-v2-testnet.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Code Climate has analyzed commit b837ec79 and detected 2 issues on this pull request.
Here's the issue category breakdown:
Category | Count |
---|---|
Duplication | 2 |
View more on Code Climate.
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Name | Link |
---|---|
Latest commit | b837ec790dce0eade008f6a3bad66cb0f7f30f9a |
Latest deploy log | https://app.netlify.com/sites/kleros-v2-testnet-devtools/deploys/672b13d0058a0d00088b60d6 |
Deploy Preview | https://deploy-preview-1738--kleros-v2-testnet-devtools.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
PR-Codex overview
This PR removes the
TestnetBanner
component from theHeader
. It simplifies the header layout by adjusting padding and eliminating the conditional rendering of the banner based on the deployment environment.Detailed summary
web/src/layout/Header/TestnetBanner.tsx
.TestnetBanner
fromindex.tsx
.<TestnetBanner />
based onisProductionDeployment()
.HeaderContainer
from4px 24px 8px
to8px 24px
.Summary by CodeRabbit
New Features
Bug Fixes
Chores