search

kleros / openiico-contract

Contract of Interactive Coin Offering
MIT License
11 stars 5 forks source link

IICO should not accept bids with maxValuation lower than the amount of already submitted ETH #31

Closed stefek99 closed 6 years ago

stefek99 commented 6 years ago

But...

The valuation is known after the finalize.

So when someone sends 100000 ether at 1 wei valuation...

These are small details, mostly around common sense and input sanitization.

clesaege commented 6 years ago

Well people can withdraw their bids, so you may still want to submit bids at a valuation lower than the current one. And even if it was not possible, this should be dealt at the UI level not the smart contract one. The smart contracts must prevent malicious behaviour, the UI must prevent the stupid ones.

stefek99 commented 6 years ago

The smart contracts must prevent malicious behaviour, the UI must prevent the stupid ones.

That's a great material for a tweet :)

clesaege commented 6 years ago

Yes sir: https://twitter.com/clesaege/status/1001520815693844480 :p