Closed dzid26 closed 2 weeks ago
Hello, thanks for your input! Unfortunately, the maxViewportTime does not seem to work correctly. No matter what value I put the viewport width does not change. It seems to be stuck at 5s no matter what.
https://github.com/klonyyy/STMViewer/assets/10755893/f0bd79e8-a1f5-49a3-823f-a9bcc62a68d2
Ok, I see the deficiency.
What is desired behavior?:
Default viewport time[s]
acquisition setting was changedDefault viewport time[s]
Default viewport time[s]
range if the viewport range is narrower than it - to avoid too fast scrollingDefault viewport time[s]
acquisition setting after it was modified by zooming the axis with the mouseDefault viewport time[s]
altogether, since it can be set directly using mouse scroll or axis setting. I have to use it a bit more to get the feel what is best.
Side note, changing the viewport range (with the mouse) during pause is unrelated from changing it during acquisition. This was not intended, but I don't see how to save range changes during pause or even what would be desired behavior. During pause ranges don't have to be the same for different subplots so it kind of doesn't make sense to save one of them. So I think current behavior is good enough. That being said, I think X axis and should be linked by default. But I think it doesn't works if there is at least one bar plot. Let me not mud the water.
After using it a bit more, I think it only makes to either leave it as is or remove Default viewport time[s]
from acquisition settings and hardcode a default (to be used when opening the app for the first time).
Another not ideal behavior manifests itself during the STOP state. Since the subplots X axes are allowed not to be linked, only the last (bottom) plot is used for the range when starting the acquisition.
https://github.com/klonyyy/STMViewer/assets/841061/c7fcd218-2b3e-4087-9fa1-0133dfd6fbf3
This could be solved by always linking all "curve" axes natively. I think they should be always linked. But first #67 needs to be solved.
https://github.com/klonyyy/STMViewer/commit/edbd032e0be50dd8f5462b05b548ef4c91d5112b makes use of system clock to update time axis limit:
https://github.com/klonyyy/STMViewer/commit/e336bddda9670bc6fb90159208dec5f5263f0e10 enables axis limits alterations during acquisition. Mouse wheel can be used to zoom in and out. Closes #54 The plot limits expansion at the beginning of the acquisition which makes zooming logic more robust.