kmod-project / kmod

kmod - Linux kernel module handling
GNU Lesser General Public License v2.1
50 stars 39 forks source link

Fixup code coverage, add to CI #229

Closed evelikov closed 3 weeks ago

evelikov commented 3 weeks ago

This PR starts off with a trivial annoyance fix the last day or so - removing the tests, use Ubuntu 24 for CodeQL.

Then an earlier commit of mine is reverted which broke the code coverage and finally a CI action is added. For the last piece a CodeCov account is needed + trivial setup for the CODECOV_TOKEN.

Edit: here is an illustrative link to the CodeCov web UI https://app.codecov.io/github/evelikov/kmod

codecov-commenter commented 3 weeks ago

Welcome to Codecov :tada:

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

:information_source: You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered :open_umbrella:

evelikov commented 3 weeks ago

@stoeckmann the first commit means we don't get any more CodeQL complains in the tests, as seen in your earlier PR.

@lucasdemarchi not 100% if you already have CodeCov account or the above welcome message is because of mine. I suspect the latter isn't enough - the token is created against my fork and not the upstream repo.

evelikov commented 3 weeks ago

If we find the PR notifications to be too much (say thee threshold is too low so new PRs are repeatedly flagged as low coverage), we can tweak them via the codecov.yml file.

evelikov commented 3 weeks ago

As indicated the Ubuntu 22.04 is still semi-borked and I'm somewhat tempted to remove it. All other distros have one version/variant and the newer Ubuntu 24.04 seems stable - famous last words...

lucasdemarchi commented 3 weeks ago

Added the same commit as in #229 here. Let's see if it passes now.

evelikov commented 3 weeks ago

I think you meant #235 and yes it does. Thanks a bunch

lucasdemarchi commented 3 weeks ago

Applied, thanks