kmod-project / kmod

kmod - Linux kernel module handling
GNU Lesser General Public License v2.1
50 stars 39 forks source link

libkmod: Improve comment in libkmod-index.c #241

Closed stoeckmann closed 1 week ago

stoeckmann commented 2 weeks ago

The 0xB007FA57 (INDEX_MAGIC_OLD) magic is very old, since it was already old in kmod v1. Let's not talk about "newer binary files" when refering to 0xB007F457 (INDEX_MAGIC) anymore. Restructured the sentence to make it easier to understand after comments were moved from libkmod-index.h to libkmod-index.c (see here for an example how the sentence was more fitting back then).

While at it, added another commit which fixes a typo in another comment.

CC: @Maaxxs

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Files with missing lines Coverage Δ
libkmod/libkmod-index.c 50.82% <ø> (ø)
shared/missing.h 100.00% <ø> (ø)

🚨 Try these New Features:

lucasdemarchi commented 1 week ago

Applied, thanks