search

knative-extensions / backstage-plugins

Knative plugins for Backstage.
Apache License 2.0
2 stars 17 forks source link

readme changes for ingress configuration #65

Closed Shashankft9 closed 1 month ago

Shashankft9 commented 1 month ago

Changes

/kind

Fixes #

Release Note

Docs

knative-prow[bot] commented 1 month ago

@Shashankft9: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/knative-extensions/backstage-plugins/pull/65): > > > > ># Changes > > > >- adds steps to make backstage accessible over ingress rules > > >/kind > > >Fixes # > > > >**Release Note** > > >```release-note > >``` > >**Docs** > > >```docs > >``` > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
aliok commented 1 month ago

@Shashankft9 added 2 suggestions. Could you please check?

knative-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, Shashankft9

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/backstage-plugins/blob/main/OWNERS)~~ [aliok] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment