search

knative-extensions / backstage-plugins

Knative plugins for Backstage.
Apache License 2.0
3 stars 19 forks source link

RBAC token to be passed from the plugin to the event mesh backend #66

Closed ahmetcihank closed 5 months ago

ahmetcihank commented 5 months ago

In terms of #34 i have added token to broker and event type consumers...

regards.

pierDipi commented 5 months ago

/cc @aliok

aliok commented 5 months ago

Thanks for your great work @ahmetcihank 🎉

Added a few comments, but they're small change requests.

Can you update the documentation though? We need to document the procedure of creating a SA, getting a token from it and passing it to the plugin in app-config.yaml.

Also, we need to remove informers and listers as we're not using them anymore, but we can do it in a separate PR.

aliok commented 5 months ago

Made some improvements here: https://github.com/ahmetcihank/backstage-plugins/pull/1

We're almost there :)

aliok commented 5 months ago

I just pushed some commits now @ahmetcihank

aliok commented 5 months ago

@ahmetcihank @pierDipi one more review?

ahmetcihank commented 5 months ago

@ahmetcihank @pierDipi one more review?

@aliok Thanks a lot , yes, all fine for me. I should have fixed the error checking , sorry :) i forgot. @pierDipi

knative-prow[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetcihank, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/backstage-plugins/blob/main/OWNERS)~~ [pierDipi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment